Skip to content

Updates for v0.3.x #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 27, 2021
Merged

Updates for v0.3.x #66

merged 16 commits into from
Sep 27, 2021

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Sep 20, 2021

Fixes #64

@eldruin eldruin requested a review from a team as a code owner September 20, 2021 07:53
@rust-highfive
Copy link

r? @posborne

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against v0.3.x. Please double check that you specified the right target!

@rust-highfive rust-highfive added S-waiting-on-review Status: Review is incomplete T-embedded-linux labels Sep 20, 2021
@eldruin
Copy link
Member Author

eldruin commented Sep 20, 2021

Yeah, the MSRV is effectively broken due to the bitflags dependency. The MSRV is now actually 1.46.0.
I guess we have three alternatives here:

  1. Raise MSRV and release 0.3.1. a.k.a. acknowledge status-quo
  2. Raise MSRV and release this as 0.4.0. (0.3 stays broken. Weird for people using 0.4.0-alpha.0)
  3. Do not release this: 0.3 stays broken until we publish 0.4, which may take a long time.

Given the current situation and that not a single issue has been opened due to the broken state of the MSRV, I would go with 1.

@nastevens
Copy link
Member

@eldruin I agree - 1 seems like the most generally useful move.

@eldruin
Copy link
Member Author

eldruin commented Sep 27, 2021

bors try

bors bot added a commit that referenced this pull request Sep 27, 2021
@bors
Try #66:
bb89a07
@bors
Copy link
Contributor

bors bot commented Sep 27, 2021

try

Build succeeded:

@eldruin
Copy link
Member Author

eldruin commented Sep 27, 2021

The current state of this PR represents option 1 now and can be merged for a 0.3.1 release

ryankurte
ryankurte approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eldruin
Copy link
Member Author

eldruin commented Sep 27, 2021

bors r=ryankurte

@bors
Copy link
Contributor

bors bot commented Sep 27, 2021

Build succeeded:

@bors bors bot merged commit 72af109 into rust-embedded:v0.3.x Sep 27, 2021
@eldruin eldruin deleted the 0.3-updates branch September 27, 2021 22:12
@posborne posborne mentioned this pull request Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankurte ryankurte ryankurte approved these changes

Assignees

@posborne posborne

Labels
S-waiting-on-review Status: Review is incomplete T-embedded-linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eldruin @rust-highfive @nastevens @ryankurte @posborne