Update gpio-cdev to 0.4.0 and add async-tokio feature #55
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nastevens (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
S-waiting-on-review
|
lgtm, thanks! bors r+ |
|
👎 Rejected by too few approved reviews |
55: Update gpio-cdev to 0.4.0 and add async-tokio feature r=ryankurte a=dfrankland It'd be lovely to allow streaming of chip line events asynchronously now that `gpio-cdev` supports it. Co-authored-by: Dylan Frankland <[email protected]>
|
Timed out. |
|
... bors retry |
55: Update gpio-cdev to 0.4.0 and add async-tokio feature r=ryankurte a=dfrankland It'd be lovely to allow streaming of chip line events asynchronously now that `gpio-cdev` supports it. Co-authored-by: Dylan Frankland <[email protected]>
|
Timed out. |
|
Thanks @dfrankland. Could you rebase this to master now that we switched to GitHub Actions instead of Travis? |
Allows streaming of chip line events asynchronously
dfrankland
force-pushed
the
async-tokio
branch
from
83008e2 to
0e9d018
Compare
|
My apologies, I just got back from a holiday. This PR is rebased now. |
|
😬 It looks like we might need to up the minimum supported Rust version to 1.36.0 according to This is due to https://github.com/rust-embedded/linux-embedded-hal/pull/55/checks?check_run_id=1874086666 |
The README.md was previously updated due to the dependency on `nix` with PR rust-embedded#42
59: Note the change to the MSRV in the changelog r=ryankurte a=eldruin After merging #55 Co-authored-by: Diego Barrios Romero <[email protected]>
It'd be lovely to allow streaming of chip line events asynchronously now that
gpio-cdevsupports it.