Update spidev dependencies #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
S-waiting-on-review
posborne
approved these changes
Sep 17, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 17, 2019
23: Update spidev dependencies r=posborne a=iicurtis Currently dependencies have to be compiled multiple times due to version mismatches. Upgrading to `spidev=0.4` fixes that problem. Before: ``` ├── linux-embedded-hal v0.2.2 │ ├── cast v0.2.2 │ ├── embedded-hal v0.2.3 (*) │ ├── i2cdev v0.4.2 │ │ ├── bitflags v1.1.0 │ │ ├── byteorder v1.3.2 │ │ ├── libc v0.2.62 │ │ └── nix v0.14.1 │ │ ├── bitflags v1.1.0 (*) │ │ ├── cfg-if v0.1.9 │ │ ├── libc v0.2.62 (*) │ │ └── void v1.0.2 (*) │ ├── spidev v0.3.0 │ │ ├── bitflags v0.3.3 │ │ ├── libc v0.2.62 (*) │ │ └── nix v0.6.0 │ │ ├── bitflags v0.4.0 │ │ ├── cfg-if v0.1.9 (*) │ │ ├── libc v0.2.62 (*) │ │ └── void v1.0.2 (*) │ │ [build-dependencies] │ │ ├── rustc_version v0.1.7 │ │ │ └── semver v0.1.20 │ │ └── semver v0.1.20 (*) │ └── sysfs_gpio v0.5.4 │ └── nix v0.14.1 (*) ``` After: ``` ├── linux-embedded-hal v0.2.2 │ ├── cast v0.2.2 │ ├── embedded-hal v0.2.3 (*) │ ├── i2cdev v0.4.2 │ │ ├── bitflags v1.1.0 │ │ ├── byteorder v1.3.2 │ │ ├── libc v0.2.62 │ │ └── nix v0.14.1 │ │ ├── bitflags v1.1.0 (*) │ │ ├── cfg-if v0.1.9 │ │ ├── libc v0.2.62 (*) │ │ └── void v1.0.2 (*) │ ├── nb v0.1.2 (*) │ ├── serial-core v0.4.0 │ │ └── libc v0.2.62 (*) │ ├── serial-unix v0.4.0 │ │ ├── ioctl-rs v0.1.6 │ │ │ └── libc v0.2.62 (*) │ │ ├── libc v0.2.62 (*) │ │ ├── serial-core v0.4.0 (*) │ │ └── termios v0.2.2 │ │ └── libc v0.2.62 (*) │ ├── spidev v0.4.0 │ │ ├── bitflags v1.1.0 (*) │ │ ├── libc v0.2.62 (*) │ │ └── nix v0.14.1 (*) │ └── sysfs_gpio v0.5.4 │ └── nix v0.14.1 (*) ``` Co-authored-by: Isaac Curtis <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently dependencies have to be compiled multiple times due to version mismatches. Upgrading to
spidev=0.4fixes that problem.Before:
After: