Skip to content

Conversation

@a-gavin
Copy link
Contributor

@a-gavin a-gavin commented Aug 7, 2022

Fixes #86

@a-gavin a-gavin requested a review from a team as a code owner August 7, 2022 20:50
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jamesmunns (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Aug 7, 2022
@a-gavin
Copy link
Contributor Author

a-gavin commented Aug 9, 2022

Not really sure why the CI fails here. Output on failing line visually looks the same.

The failing line of the script is here.

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!
The CI broke due to an upstream change but it has now been fixed.
bors r+

@bors
Copy link
Contributor

bors bot commented Aug 11, 2022

Build succeeded:

@bors bors bot merged commit bac18e0 into rust-embedded:master Aug 11, 2022
@a-gavin a-gavin deleted the fix_exception_objdump_output branch August 17, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exception Handling vector table objdump addresses inconsistent

4 participants