Enforce clippy in CI

[Dirbaio]

Depends on #394

CI wasn't actually enforcing clippy, because actions-rs/clippy-check needs to run as pull_request_target to get the token to add the "fancy" comments to the diff. It does nothing when ran as pull_request.

pull_request_target is troublesome because it uses the yaml from master instead of from the PR branch, which means when bumping clippy you don't know whether CI passes until after it's merged. I've made it use cargo clippy instead, which works on pull_request.

[rust-highfive]

r? @ryankurte

(rust-highfive has picked a reviewer for you, use r? to override)

[eldruin]

I am not a fan of enforcing clippy. Using the nightly clippy is probably even more volatile.
Granted, it is pinned to a version that works fine now, but we will update it regularly and I see us making unnecessary/unrelated/even contestable changes in unrelated crates in order to land PRs.
For me, the failing ❌ icon in CI is enough warning when reviewing a PR.

[eldruin]

This should be noted in the changelog.

[Dirbaio]

If we keep clippy but not enforcing it, the moment we decide to not fix a warning because we don't agree with it, all following PRs will have the red ❌ forever, due to an issue unrelated to the PR. At that point it stops being a useful flag for code review, and it's also confusing for contributors because a red ❌ in a PR usually means you did something wrong.

IMO if we keep it we should enforce it, otherwise we should remove it.

[Dirbaio]

making unnecessary/unrelated/even contestable changes in unrelated crates in order to land PRs.

Random warnings won't appear when landing a feature PR, because the clippy version is pinned. We can update it in dedicated PRs, so the changes for any new warnings don't mix with normal PRs.

[eldruin]

Up to you @ryankurte, @therealprof

[therealprof]

LGTM, thanks.

bors r+

[bors]

Build succeeded:

• clippy
• fmt
• test (1.54.0, thumbv6m-none-eabi)
• test (1.54.0, thumbv7m-none-eabi)
• test (1.54.0, x86_64-unknown-linux-gnu)
• test (nightly, thumbv6m-none-eabi)
• test (nightly, thumbv7m-none-eabi)
• test (nightly, x86_64-unknown-linux-gnu)
• test (stable, thumbv6m-none-eabi)
• test (stable, thumbv7m-none-eabi)
• test (stable, x86_64-unknown-linux-gnu)