Add changelog checker for PRs #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ryankurte (rust-highfive has picked a reviewer for you, use r? to override) |
|
bors try |
eldruin
force-pushed
the
changelog-checker
branch
2 times, most recently
from
1db62fa to
74ddbb5
Compare
|
Alright, now it works |
tryAlready running a review |
Disasm
reviewed
Jul 9, 2021
eldruin
force-pushed
the
changelog-checker
branch
from
74ddbb5 to
b139fe9
Compare
bors bot
added a commit
that referenced
this pull request
Jul 13, 2021
290: Add changelog checker for PRs r=therealprof a=eldruin A bit ironic that adding the checker requires deactivating it, haha Co-authored-by: Diego Barrios Romero <[email protected]>
tryTimed out. |
|
Ah, it seems the changelog checker does not work well with bors since deactivating the changelog check for a PR does not generate any output at all for it in the status and thus bors waits forever for it. |
|
I think you just don't make bors require it, but it can still run for PRs to remind people to add a changelog. |
|
Timed out. |
|
@adamgreig Thanks for the idea. That would be possible, yes. Not great but I guess better than nothing. |
eldruin
force-pushed
the
changelog-checker
branch
from
b139fe9 to
7d751ba
Compare
|
bors r+ |
|
👎 Rejected by too few approved reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit ironic that adding the checker requires deactivating it, haha