Skip to content

Enable doctests and fix them #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2020
Merged

Enable doctests and fix them #221

merged 1 commit into from
Jun 16, 2020

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Jun 10, 2020

I discovered that due to a typo some doctests were not being run.
A couple small fixes were also necessary for them to compile.

@eldruin eldruin requested review from ilya-epifanov and a team as code owners June 10, 2020 13:21
@rust-highfive
Copy link

r? @ithinuel

(rust_highfive has picked a reviewer for you, use r? to override)

therealprof
therealprof approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 16, 2020

Build succeeded:

@bors bors bot merged commit f72c91d into rust-embedded:master Jun 16, 2020
@eldruin eldruin deleted the fix-doctests branch June 16, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

@ilya-epifanov ilya-epifanov Awaiting requested review from ilya-epifanov

Assignees

@ithinuel ithinuel

Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eldruin @rust-highfive @therealprof @ithinuel