Skip to content

Add thumbv8m main. #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2019
Merged

Add thumbv8m main. #130

merged 2 commits into from
Jan 19, 2019

Conversation

nezza
Copy link
Contributor

@nezza nezza commented Jan 16, 2019

rustup supports the thumbv8m.main-none-eabi target, this adds support for thumbv8m.main-none-eabi to cortex-m.

Related PRs:

rust-embedded/cortex-m-semihosting#28
rust-embedded/cortex-m-rt#167

Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks @nezza.

@rust-embedded/cortex-m any objections to merging this? I note thumbv8m.main-none-eabi is still nightly-only at the moment.

@korken89
Copy link
Contributor

I see no issue as long as it is stated in the docs

@adamgreig
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jan 19, 2019
130: Add thumbv8m main. r=adamgreig a=nezza

rustup supports the `thumbv8m.main-none-eabi` target, this adds support for `thumbv8m.main-none-eabi` to cortex-m.


Related PRs:

rust-embedded/cortex-m-semihosting#28
rust-embedded/cortex-m-rt#167

Co-authored-by: Thomas Roth <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 19, 2019

Build succeeded

@bors bors bot merged commit 21ee7ef into rust-embedded:master Jan 19, 2019
@adamgreig adamgreig mentioned this pull request Jan 28, 2019
bors bot added a commit to rust-embedded/cortex-m-semihosting that referenced this pull request Mar 15, 2019
28: Add thumbv8m main. r=adamgreig a=nezza

rustup supports the `thumbv8m.main-none-eabi` target, this adds support for `thumbv8m.main-none-eabi` to cortex-m-semihosting.

Related PRs:

rust-embedded/cortex-m#130
rust-embedded/cortex-m-rt#167

Co-authored-by: Thomas Roth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants