This repository was archived by the owner on Dec 2, 2020. It is now read-only.
Add thumbv8m main. #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2019
|
The Travis build is failing because it relies on cortex-m supporting thumbv8m.main already - after the PR in cortex-m is integrated it should work. |
bors bot
added a commit
to rust-embedded/cortex-m
that referenced
this pull request
Jan 19, 2019
130: Add thumbv8m main. r=adamgreig a=nezza rustup supports the `thumbv8m.main-none-eabi` target, this adds support for `thumbv8m.main-none-eabi` to cortex-m. Related PRs: rust-embedded/cortex-m-semihosting#28 rust-embedded/cortex-m-rt#167 Co-authored-by: Thomas Roth <[email protected]>
Disasm
added
the
S-blocked
|
Hopefully we can merge this after #32 is merged. |
|
bors try |
adamgreig
added
S-waiting-on-review
T-cortex-m
and removed
S-blocked
tryBuild succeeded |
|
bors r+ |
|
👎 Rejected by too few approved reviews |
adamgreig
approved these changes
Mar 15, 2019
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Mar 15, 2019
28: Add thumbv8m main. r=adamgreig a=nezza rustup supports the `thumbv8m.main-none-eabi` target, this adds support for `thumbv8m.main-none-eabi` to cortex-m-semihosting. Related PRs: rust-embedded/cortex-m#130 rust-embedded/cortex-m-rt#167 Co-authored-by: Thomas Roth <[email protected]>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustup supports the
thumbv8m.main-none-eabitarget, this adds support forthumbv8m.main-none-eabito cortex-m-semihosting.Related PRs:
rust-embedded/cortex-m#130
rust-embedded/cortex-m-rt#167