Skip to content

Use much less memory in I2C interface #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Use much less memory in I2C interface #13

merged 1 commit into from
Mar 20, 2018

Conversation

jamwaffles
Copy link
Collaborator

Gone from 1025 byte buffer down to 17, although sending data to the display is marginally less efficient. Should be fine.

@scowcron This is from your rust-ssd1306 crate. Any thoughts?

Fixes #6.

Gone from 1025 byte buffer down to 17, although sending data to the
display is marginally less efficient. Should be fine.
@jamwaffles jamwaffles self-assigned this Mar 20, 2018
@scowcron
Copy link
Collaborator

other than the CI not working, looks good.

I was getting ready to submit a near identical PR. The old way would have failed on stm32f30x anyway.

I don't think there's anything to worry about sending an extra 64 bytes for every 1k at this scale. I'd rather eliminate the buffer entirely but the changes haven't come down yet that make that possible.

Ship it.

@jamwaffles
Copy link
Collaborator Author

I'll remove CircleCI until we decide what to do with CI in general. Forgot I added it tbh.

Good catch on the stm32f30x. I'm using the stm32f103 so there's probably a bunch of stuff I'm missing.

I'm not too bothered about the memory usage. Maybe on an AVR or PIC but not on these ARM chips.

@jamwaffles jamwaffles merged commit 9b63742 into master Mar 20, 2018
@scowcron
Copy link
Collaborator

That stm32f30x is important because that's what japaric uses in all of his examples, which since he's the guy leading the charge means that's what a lot of people who try to pick this stuff up for the first time are going to be using. I have the f3 board he uses all the time, so I can be testing against that.

@jamwaffles jamwaffles deleted the leaner-i2c branch March 20, 2018 21:36
@jamwaffles
Copy link
Collaborator Author

Yeah I've seen some of his neato accelerometer stuff he's done with that chip. It's good to have a range of test hardware!

@jamwaffles jamwaffles mentioned this pull request Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants