Skip to content

Fix duplicate buffer in I2C code #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamwaffles opened this issue Mar 19, 2018 · 2 comments
Closed

Fix duplicate buffer in I2C code #6

jamwaffles opened this issue Mar 19, 2018 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jamwaffles
Copy link
Collaborator

send_data() should be using less memory. @scowcron's implementation uses buffered chunks which might be a good way to go. Adding the initial 0x40 to the beginning of the buffer makes using another buffer a necessity at the moment.

@jamwaffles jamwaffles added the bug Something isn't working label Mar 19, 2018
@scowcron
Copy link
Collaborator

relevant, I think: rust-embedded/embedded-hal#47

@jamwaffles
Copy link
Collaborator Author

That looks good. Until that gets merged/implemented though, I think the best way to go is to port over your chunked tx buffer idea. 17 bytes isn't much, even for a uC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants