refactor(env): optimize and reduce allocations #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasbeyer
approved these changes
Jun 8, 2021
Merged
|
Well, CI says no. For the clippy lints, simply rebase to master please. The other things (the rustfmt failure) have to be fixed, of course! |
|
Rebased and formatted 👍 |
matthiasbeyer
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a slow test involving config and I thought that optimizing this module would make it better.
Unfortunately for me, the test is still slow after these changes (the problem is probably elsewhere instead of config), but I thought it was worth opening a PR anyway, as you may want to add them.