Skip to content

Function evaluation #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 9, 2018
Merged

Function evaluation #131

merged 14 commits into from
Jul 9, 2018

Conversation

virgil-serbanuta
Copy link
Contributor

No description provided.

@virgil-serbanuta virgil-serbanuta force-pushed the function-evaluation branch 4 times, most recently from ebfee3c to 67832db Compare June 28, 2018 11:27
@virgil-serbanuta virgil-serbanuta changed the title Function evaluation - DO NOT REVIEW YET Function evaluation Jul 4, 2018
@virgil-serbanuta virgil-serbanuta requested a review from traiansf July 4, 2018 12:18
traiansf
traiansf approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@traiansf traiansf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK in general. I'm not convinced though about and-ing patterns without checking sorts, and also, I'm not sure how easy it would be to extract a demo from the evaluation process.

src/main/haskell/language-kore/src/Data/Kore/AST/PureML.hs Outdated
@@ -2,6 +2,7 @@
{-# LANGUAGE FlexibleInstances #-}
{-# LANGUAGE GADTs #-}
{-# LANGUAGE MultiParamTypeClasses #-}
{-# LANGUAGE PatternSynonyms #-}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still used?

src/main/haskell/language-kore/src/Data/Kore/AST/PureML.hs Outdated
@@ -32,6 +33,10 @@ asPurePattern
:: Pattern level var (PureMLPattern level var) -> PureMLPattern level var
asPurePattern = Fix

fromPurePattern
:: PureMLPattern level var -> Pattern level var (PureMLPattern level var)
fromPurePattern (Fix p) = p
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe fromPurePattern = unFix ?

@virgil-serbanuta
Copy link
Contributor Author

And-ing patterns: I hope that Data.Kore.ASTUtils.SmartConstructors would make this easier after #137 gets submitted.

@virgil-serbanuta virgil-serbanuta merged commit 561d0e3 into runtimeverification:master Jul 9, 2018
@virgil-serbanuta virgil-serbanuta deleted the function-evaluation branch July 9, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@traiansf traiansf traiansf approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@virgil-serbanuta @traiansf