Skip to content

Conversation

@cristiano-pacheco
Copy link
Collaborator

@cristiano-pacheco cristiano-pacheco commented Mar 31, 2023

It resolves issue #7

  • PHPStan
  • Code sniffer
  • Mess detector
  • Unit tests

@cristiano-pacheco cristiano-pacheco requested a review from mwr March 31, 2023 01:16
@cristiano-pacheco cristiano-pacheco self-assigned this Mar 31, 2023
@mwr
Copy link
Member

mwr commented Mar 31, 2023

@cristiano-pacheco We should not start using "@phpstan-ignore-line" for default Magento stuff.
There is solutions for it, maybe lets align about how we can address this

@cristiano-pacheco cristiano-pacheco marked this pull request as ready for review March 31, 2023 13:25
@cristiano-pacheco cristiano-pacheco merged commit 06afa8b into develop Apr 6, 2023
@cristiano-pacheco cristiano-pacheco deleted the feature/#7-static-tests branch April 6, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants