Skip to content

Fix PHP 8.4 compatibility #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

Fix PHP 8.4 compatibility #43

merged 1 commit into from
Oct 15, 2025

Conversation

@bramstroker
Copy link
Contributor

@bramstroker bramstroker commented Aug 5, 2025 •
edited
Loading

Fixes:

Deprecated Functionality: RunAsRoot\MessageQueueRetry\Plugin\HandleQueueMessageRejectPlugin::aroundReject(): Implicitly marking parameter $rejectionMessage as nullable is deprecated, the explicit nullable type must be used instead in vendor/run-as-root/magento2-message-queue-retry/src/Plugin/HandleQueueMessageRejectPlugin.php on line 26

@bramstroker
fix: explicit nullable type php 8.4
d375a8e 
Fix 8.4 deprecation warning
@MathijsvVelde
Copy link

MathijsvVelde commented Oct 7, 2025

+1

@MathijsvVelde MathijsvVelde mentioned this pull request Oct 7, 2025
Closed
@DavidLambauer DavidLambauer merged commit 88e113e into run-as-root:develop Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidLambauer DavidLambauer DavidLambauer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bramstroker @MathijsvVelde @DavidLambauer