Skip to content

Explicitly deprecate rubyforge_project #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Jun 20, 2019
Merged

Explicitly deprecate rubyforge_project #2798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6912ebf
Silence deprecations when gemdeps is used in tests
deivid-rodriguez Jun 20, 2019
9094740
Explicitly deprecate `rubyforge_project`
deivid-rodriguez Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/rubygems/specification.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,7 @@ def test_files=(files) # :nodoc:
# Formerly used to set rubyforge project.

attr_writer :rubyforge_project
deprecate :rubyforge_project=, :none, 2019, 12

##
# The Gem::Specification version of this gemspec.
Expand Down
6 changes: 4 additions & 2 deletions test/rubygems/test_gem.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1786,8 +1786,10 @@ def test_use_gemdeps_missing_gem

EXPECTED

assert_output nil, expected do
Gem.use_gemdeps
Gem::Deprecate.skip_during do
assert_output nil, expected do
Gem.use_gemdeps
end
end
ensure
ENV['RUBYGEMS_GEMDEPS'] = rubygems_gemdeps
Expand Down