All `gem` commands print warnings on master+3.1.0pre2, if certain gems are installed

[duckinator]

My current problem is that running any gem command results in warnings about Gem::Specification#rubyforge_project= for _every gem you have installed that uses rubyforge_project = ... in their gemspec.

Unfortunately, two such gems are on my system because I use Vagrant for some things (erubis and a 3+ year old version of childprocess).

This issue is related to:

• Network problems
• Installing a library
• Publishing a library
• The command line gem
• Other

Here are my current environment details, which conveniently demonstrates the problem:

$ gem env version
NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01.
Gem::Specification#rubyforge_project= called from /usr/share/gems/specifications/childprocess-0.5.9.gemspec:16.
NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01.
Gem::Specification#rubyforge_project= called from /usr/share/gems/specifications/erubis-2.7.0.gemspec:17.
3.1.0.pre2

I will abide by the code of conduct.

[bronzdoc]

@duckinator How is that a bug?

They should remove that from their gemspec. rubyforge_project= is deprecated and not encouraged to use isn't it?

Thought you were using those gems specifically 🙈. Will give this a look

[bronzdoc]

@duckinator I poked around this and i'm not able to reproduce it.

➜  rubygems git:(97e97686) ✗ gem list | grep erubis
erubis (2.7.0)
➜  rubygems git:(97e97686) ✗ gem env version
3.1.0.pre2

Can you share your gem env?

[duckinator]

Output of `gem env`

NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01.
Gem::Specification#rubyforge_project= called from /usr/share/gems/specifications/childprocess-0.5.9.gemspec:16.
NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01.
Gem::Specification#rubyforge_project= called from /usr/share/gems/specifications/erubis-2.7.0.gemspec:17.
RubyGems Environment:
  - RUBYGEMS VERSION: 3.1.0.pre2
  - RUBY VERSION: 2.6.3 (2019-04-16 patchlevel 62) [x86_64-linux]
  - INSTALLATION DIRECTORY: /usr/share/gems
  - USER INSTALLATION DIRECTORY: /home/puppy/.gem/ruby/2.6.0
  - RUBY EXECUTABLE: /usr/bin/ruby
  - GIT EXECUTABLE: /usr/bin/git
  - EXECUTABLE DIRECTORY: /usr/bin
  - SPEC CACHE DIRECTORY: /home/puppy/.gem/specs
  - SYSTEM CONFIGURATION DIRECTORY: /etc
  - RUBYGEMS PLATFORMS:
    - ruby
    - x86_64-linux
  - GEM PATHS:
     - /usr/share/gems
     - /home/puppy/.gem/ruby/2.6.0
     - /usr/local/share/gems
  - GEM CONFIGURATION:
     - :update_sources => true
     - :verbose => true
     - :backtrace => false
     - :bulk_threshold => 1000
     - "gem" => "--suggestions --user-install --no-document"
  - REMOTE SOURCES:
     - https://rubygems.org/
  - SHELL PATH:
     - /home/puppy/.cargo/bin
     - /home/puppy/.cargo/bin
     - /home/puppy/bin
     - /home/puppy/.local/bin
     - /home/puppy/.gem/ruby/bin
     - /home/puppy/.npm-global/bin
     - /home/puppy/go/bin
     - /usr/bin
     - /usr/sbin
     - /usr/local/bin
     - /usr/local/sbin
     - /home/puppy/.gem/ruby/2.6.0/bin
     - /var/lib/flatpak/exports//bin

I also discovered that require 'rubygems/gem_runner' was enough to reproduce it.

I was then able to narrow that down to Gem.load_plugins, and ultimately to this block in Gem.find_latest_files():

    files.concat Gem::Specification.latest_specs(true).map { |spec|
      spec.matches_for_glob("#{glob}#{Gem.suffix_pattern}")
    }.flatten

[duckinator]

Just further simplified that to Gem::Specification._all, and then narrowed it down to one line of that function:

      @@all = stubs.map(&:to_spec)

And, going off of that,

$ ruby -e 'Gem::Specification.stubs.map(&:to_spec)'
NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01.
Gem::Specification#rubyforge_project= called from /usr/share/gems/specifications/childprocess-0.5.9.gemspec:16.
NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01.
Gem::Specification#rubyforge_project= called from /usr/share/gems/specifications/erubis-2.7.0.gemspec:17.
$ 

[lucaszmoraes]

following

[duckinator]

Reproduced on Fedora 30 using RubyGems 3.1.1 + childprocess/erubis gems installed via dnf (not RubyGems); can't reproduce in a Debian-based Docker container. Going to try a Fedora-based Docker container, now.

[duckinator]

I can reproduce on the Fedora 30 docker image, but not the Fedora 31 docker image:

$ docker run --rm -it fedora:30 /bin/bash -c 'dnf install -y ruby rubygems rubygem-erubis >/dev/null && gem update --system --install-dir=/usr/share/gems --bindir /usr/local/bin >/dev/null && gem env version'
NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01.
Gem::Specification#rubyforge_project= called from /usr/share/gems/specifications/erubis-2.7.0.gemspec:17.
NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01.
Gem::Specification#rubyforge_project= called from /usr/share/gems/specifications/erubis-2.7.0.gemspec:17.
NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01.
Gem::Specification#rubyforge_project= called from /usr/share/gems/specifications/erubis-2.7.0.gemspec:17.
3.1.1
$

[duckinator]

@lucaszmoraes what operating system/version were you encountering this on?

[duckinator]

Looks like it's fixed on Fedora 31 because:

1. Gems installed via RubyGems don't seem to cause this problem.
2. Fedora 31 patches at least some of their rubygems-* packages to remove the s.rubyforge_project = ... line.

As for Fedora 30, it's still reproducible.

[MSP-Greg]

I haven't looked at gem 'build' code, but I noticed that a repo I just forked had rubyforge_project in its gemspec. The 'versioned' gemspec of the installed gem in the specifications folder did not.

I looked at the packaged gem, and rubyforge_project doesn't appear in the gem package 'metadata'.

So, might it be the packaging system rather than the install system? I think that made sense...

[duckinator]

@MSP-Greg yeah, that could be it. I'm not too familiar with how Fedora repackages gems.