Use Random instead of SecureRandom for determinism.
#162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SecureRandom uses crypto-safe randomness sources which can't be seeded, whereas we seed the Random gem's RNG in harness-common.rb This should help the ActiveRecord benchmark behave more deterministically across runs.
Member
|
Sounds better, but you still get different |
k0kubun
approved these changes
Jan 6, 2023
Member
k0kubun
left a comment
k0kubun
left a comment
There was a problem hiding this comment.
However, I think we should just merge this first 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SecureRandomuses crypto-safe randomness sources which can't be seeded, whereas we seed theRandomgem's RNG inharness-common.rbThis should help the ActiveRecord benchmark behave more deterministically across runs.Following comment on #159