Fix tag in table_of_contents.html #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aycabta
force-pushed
the
fix-tag-in-table_of_contents
branch
from
a2f53fa to
1fe8541
Compare
RDoc::Markup::AttributeManager#convert_html that is called from RDoc::Markup::AttributeManager#flow replaces HTML tags of received "str" with "NULL" characters in HTML generation for each files, and the NULL characters are removed in RDoc::Markup::AttributeManager#split_into_flow. But the String objects are reused for table_of_contents.html generation, so the tags lose at that moment. This commit fixes it with using duplicated String object.
aycabta
force-pushed
the
fix-tag-in-table_of_contents
branch
from
1fe8541 to
dcdf4bf
Compare
Member
Author
|
This depends on #550 for that CI passes tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDoc::Markup::AttributeManager#convert_htmlthat is called fromRDoc::Markup::AttributeManager#flowreplaces HTML tags of receivedstrwithNULLcharacters in HTML generation for each files, and theNULLcharacters are removed inRDoc::Markup::AttributeManager#split_into_flow. But theStringobjects are reused for table_of_contents.html generation, so the tags lose at that moment.This Pull Request fixes it with using duplicated
Stringobject.