Set source_code_uri metadata to this gem's public repo URL #662
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's what the `bundle gem` template suggests: https://github.com/rubygems/rubygems/blob/fcb672f/bundler/lib/bundler/cli/gem.rb#L54
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, each rake gem release's
source_code_uripoints to its "releases" page URL on GitHub, e.g. https://github.com/ruby/rake/releases/v13.3.0 but that's not indeed a source_code_uri.Instead, let's simply link_to
https://github.com/ruby/rake. That's what thebundle gemtemplate suggests:https://github.com/rubygems/rubygems/blob/fcb672f/bundler/lib/bundler/cli/gem.rb#L54
and almost all documentations and test data in rubygems/bundler look like. https://github.com/search?q=repo%3Arubygems%2Frubygems%20source_code_uri&type=code
Or, IMO the name "source code URI" implies that it should at least return a URL that can be
git cloned.FYI the configuration was introduced via #328 but there wasn't any detailed discussion about the validity of the value.