add native tests runner #2
Conversation
|
👋 It seems that this PR is adding a GitHub Action workflow that looks a lot like a CI step. CI should generally be handled with Shopify Build pipelines, and GitHub Actions should be used for GitHub automation and package publishing. If this workflow change is not introducing a CI step, then feel free to ignore this comment. For more details and explanation, click to expand...GitHub Actions are generally intended for GitHub, Project or Repository-related automation, or for public package and library publishing. You can learn more about the supported use cases in our GitHub Actions documentation. If your Action is a CI step, please migrate to shopify-build instead. If you have any questions about how to setup a Note that this message is based on a simple regex detection, and may not always be accurate. If your action is not a CI step, and is already running on If your repository is intended to become Public later, please use |
|
👋 It seems that this PR is adding, or editing, a GitHub Action workflow that is not configured to use our custom GitHub Action runners. For private repositories, the only supported way of running Action workflows is via the custom runners. You can learn more about the supported use cases in our GitHub Actions documentation. To make sure that your workflow is using these runners you need to add the runs-on: shopify-ubuntu-latestIf your repository is intended to become Public later, please use If you run into any issues with the custom runners, please reach out in #help-eng-infrastructure. |
iliabylich
force-pushed
the
native-test-runner
branch
from
f28dc1e to
18af778
Compare
|
We can iterate on the format a bit, but I like this direction a lot |
We need to free the current_block_exits in parse_program when we're done
with it to prevent memory leaks. This fixes the following memory leak detected
when running Ruby using `RUBY_FREE_AT_EXIT=1 ruby -nc -e "break"`:
Direct leak of 32 byte(s) in 1 object(s) allocated from:
#0 0x5bd3c5bc66c8 in realloc (miniruby+0x616c8) (BuildId: ba6a96e5a060aec6fd9f05ed7e95d9627e1dbd74)
#1 0x5bd3c5f91fd9 in pm_node_list_grow prism/templates/src/node.c.erb:35:40
#2 0x5bd3c5f91e9d in pm_node_list_append prism/templates/src/node.c.erb:48:9
#3 0x5bd3c6001fa0 in parse_block_exit prism/prism.c:15788:17
#4 0x5bd3c5fee155 in parse_expression_prefix prism/prism.c:19221:50
#5 0x5bd3c5fe9970 in parse_expression prism/prism.c:22235:23
#6 0x5bd3c5fe0586 in parse_statements prism/prism.c:13976:27
#7 0x5bd3c5fd6792 in parse_program prism/prism.c:22508:40
2 participants
Added a test runner that
I'm not sure about the format. Any thoughts?
Also this PR includes a Makefile (and GitHub action) to run those tests (so far there are only 2 fixtures) with ASAN+LSAN.