Update OptParse#on{,_tail,_head} to use ... #115
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I've gone ahead and made changes to all places which could benefit from |
Member
|
After dropping support for 2.6 and before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
OptParse#on,OptParse#on_tail, andOptParse#on_headto use....Explicitly forwarding
*opts, &blockdoesn't work with keyword arguments anymore, so I have to dodef on(...) = define(...)in all my subclasses whenever I want to redefinedefine.While this is backwards incompatible (rubies that don't understand
...won't work), ruby 2.7 (which introduced...) has been EOL for over 2 and a half years.There's a few other places in the file which could benefit from this (eg
OptParse#parse'skeywordsargument), but I want to do a minimal PR which won't have any breaking changes.