Fix text_response and resp-text #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevans
changed the title
This was referenced Nov 9, 2020
Merged
nevans
force-pushed
the
fix-text_response_and_resp_text-RFC3501
branch
from
208670b to
9e36561
Compare
This could lead to unexpected bugs if `@next_token` was filled using one parser and lookahead is called with an incompatible parser, so I've made that an error. All matches that set lex_state should be immediately preceded by a "match" or "shift_token". Probably better would be to push/pop on a `lex_state` stack.
These are mostly useful when violating the RFCs, in order to workaround servers that violate the RFCs.
This encapsulates the `@lex_state` change.
Specifically, "text" is allowed to begin with "[" or "=". Disallowing that was an older RFC2060 restriction. (RFC 2060 was written in 1996. RFC 3501 in 2003) :)
nevans
force-pushed
the
fix-text_response_and_resp_text-RFC3501
branch
from
9e36561 to
d3566cb
Compare
Member
|
@nevans I've merged it manually. Thank you! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes e.g.:
Specifically, "text" is allowed to begin with "[" or "=". Excluding those was a an older RFC 2060 restriction.
(RFC 2060 was written in 1996. RFC 3501 in 2003) 🙂