✨ Backport UIDPlusData, AppendUIDData, CopyUIDData to v0.4 #404
+708
−123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevans
changed the title
Explicitly test how unsorted uid-sets are handled.
The class rdoc was updated to match v0.5, in order to simplify other backported commits.
In addition to letting us delete some code, this is also a step towards replacing `UIDPlusData` with new (incompatible) data structures that store UID sets directly, rather than converted into arrays of integers.
This config attribute causes the parser to use the new AppendUIDData and CopyUIDData classes instead of CopyUIDData. AppendUIDData and CopyUIDData are _mostly_ backward-compatible with UIDPlusData. Most applications should be able to upgrade with no changes. UIDPlusData will be removed in +v0.6+.
Since its only these two classes, I manually wrote a subset of the code that would be generated by `Data.define` and inherited from `Data`. The `AppendUIDData` and `CopyUIDData` class definitions are unchanged—only the superclass definition is different.
nevans
force-pushed
the
backport-0.4-uidplus-deprecation
branch
from
f40a1dc to
d32320a
Compare
nevans
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following PRs to
v0.4-stable:uid-setassequence-setwithout*#393APPENDUID/COPYUID, 🗑️ Deprecate UIDPlusData #401Note: The
Datapolyfill is not going to be backported to0.4-stable. So d32320a implements theData.definesuperclasses forAppendUIDDataandCopyUIDData.