net/imap: support IMAP4 ID extension (RFC2971) #4
+184
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevans
force-pushed
the
ID-extension-RFC-2971
branch
from
69df369 to
deb8283
Compare
IMAP servers often strongly recommend clients to report their ID, for usage statistics and bug reports. Clients may also find server IDs useful for the same reasons. Although the RFC requires otherwise, some servers do make it a soft requirement that the ID is reported (and will sometimes even disconnect clients they do not recognize). See https://tools.ietf.org/html/rfc2971 for more details.
RFC 2971 very clearly states (in section 3.2): > a server MUST send a tagged ID response to an ID command. and yet... some servers don't. Co-Authored-By: Arkadiusz Holko <[email protected]>
nevans
force-pushed
the
ID-extension-RFC-2971
branch
from
38e4efa to
4be6097
Compare
Member
|
@nevans Thank you. I've merged it manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMAP servers often strongly recommend clients to report their ID, for
usage statistics and bug reports. Clients may also find server IDs
useful for the same reasons.
Although the RFC requires otherwise, some servers do make it a soft
requirement that the ID is reported (and will sometimes even disconnect
clients they do not recognize).
See https://tools.ietf.org/html/rfc2971 for more details.
n.b. I submitted this PR previously, before net-imap was gemified: