Skip to content

✅ Add a Mutex to FakeServer (for tests only) [backport: #317] #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nevans merged 1 commit into from
Oct 13, 2024
Merged

✅ Add a Mutex to FakeServer (for tests only) [backport: #317] #336

nevans merged 1 commit into from
Oct 13, 2024

Conversation

@nevans
Copy link
Collaborator

@nevans nevans commented Oct 13, 2024 •
edited
Loading

This backports #317 from master (0.5.0-dev).

What I really want to backport is #330 and #334, and this is a prereq for those.

@nevans
✅ Add a Mutex to FakeServer (for tests only)
97d704e 
While trying to track down the cause of #287 for @hsbt, I noticed that
this is likely a race condition.  While this can't be the cause of that
issue (the failures come from tests that don't even use FakeServer), it
seems like a good idea to fix anyway, and safe.
@nevans nevans merged commit 97d704e into v0.4-stable Oct 13, 2024
@nevans nevans deleted the backport/0.4/317/add-mutex-to-fake_server branch October 13, 2024 11:56
@nevans nevans added backport This issue or PR is for a stable release branch tests-only labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This issue or PR is for a stable release branch tests-only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nevans