Skip to content

Fix encoding crash when LANG environment is empty #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025
Merged

Fix encoding crash when LANG environment is empty #1144

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52272e8
fix: handle UTF-8 history with empty LANG env
jsxs0 Jun 5, 2025
4d09cc1
fix: use String#scrub to handle encoding gracefully
jsxs0 Jun 5, 2025
209f492
Fix load_history method
jsxs0 Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions lib/debug/console.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,9 @@ def history_file
def read_history_file
if history && File.exist?(path = history_file)
f = (['', 'DAI-', 'CHU-', 'SHO-'].map{|e| e+'KICHI'}+['KYO']).sample
["#{FH}#{f}".dup] + File.readlines(path)
# Read history file and scrub invalid characters to prevent encoding errors
lines = File.readlines(path).map(&:scrub)
["#{FH}#{f}".dup] + lines
else
[]
end
Expand All @@ -193,8 +195,10 @@ def deactivate
orig_records = read_history_file
open(history_file, 'w'){|f|
(orig_records + added_records).last(max).each{|line|
if !line.start_with?(FH) && !line.strip.empty?
f.puts line.strip
# Use scrub to handle encoding issues gracefully
scrubbed_line = line.scrub.strip
if !line.start_with?(FH) && !scrubbed_line.empty?
f.puts scrubbed_line
end
}
}
Expand All @@ -204,6 +208,8 @@ def deactivate

def load_history
read_history_file.each{|line|
# Use scrub to handle encoding issues gracefully, then strip
line.scrub!
line.strip!
history << line unless line.empty?
} if history.empty?
Expand Down
Loading