Skip to content

Remove an unnecessary each call #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove an unnecessary each call #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e048b0d
Remove an unnecessary `each` call
nobu May 21, 2025
4041758
Drop ruby 2.5
nobu Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
ruby-versions:
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
with:
min_version: 2.5
min_version: 2.6
test:
needs: ruby-versions
name: build (${{ matrix.ruby }} / ${{ matrix.os }})
Expand All @@ -16,7 +16,6 @@ jobs:
ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
os: [ ubuntu-latest, macos-latest, windows-latest ]
exclude:
- { os: macos-latest, ruby: 2.5 }
- { os: windows-latest, ruby: head }
- { os: macos-latest, ruby: jruby }
- { os: windows-latest, ruby: jruby }
Expand Down
2 changes: 1 addition & 1 deletion cgi.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
spec.description = %q{Support for the Common Gateway Interface protocol.}
spec.homepage = "https://github.com/ruby/cgi"
spec.licenses = ["Ruby", "BSD-2-Clause"]
spec.required_ruby_version = ">= 2.5.0"
spec.required_ruby_version = ">= 2.6.0"

spec.metadata["homepage_uri"] = spec.homepage
spec.metadata["source_code_uri"] = spec.homepage
Expand Down
2 changes: 1 addition & 1 deletion lib/cgi/core.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ def print(*options)
#
def self.parse(query)
params = {}
query.split(/[&;]/).each do |pairs|
query.split(/[&;]/) do |pairs|
key, value = pairs.split('=',2).collect{|v| CGI.unescape(v) }

next unless key
Expand Down