Handle return when arg is an Array
#55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is pretty much exactly how I would have handled this. Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes care of handling
returnnodes when argument isn Array, with or without being wrapped in parens (bonus mode!).TBH I spent more time messing with this code then actually fixing it. I dont love how it's handling
ArrayLiteralsinsideParensbut everything else I came up with seemed like overkill or an unnecessary abstraction. I'll trust you to make the call on if this code needs to change (which I'm happy to pair on) but for now I wanted to get it working before getting it "right" (or fast)