update reload documentation #2614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested changes
Oct 21, 2025
Member
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
Thanks!
- Add to TOC.
- Do we need the troubleshooting info here? It's a feature of Rails and rails documentation provides plenty of details.
alexanderadam
force-pushed
the
doc/update_reload_documentation_for_current_Rails_versions
branch
from
1b5134c to
7eb4dc8
Compare
Contributor
Author
|
Is the reason for the manual TOC that you don't like the integrated one from GitHub? |
Member
|
The README TOC existed before GitHub had the feature I imagine. I am not against removing it along with the Danger check. |
Member
|
@alexanderadam actually, mind rebasing this? sorry for the hassle |
alexanderadam
force-pushed
the
doc/update_reload_documentation_for_current_Rails_versions
branch
from
7eb4dc8 to
0311f28
Compare
Contributor
Author
sure thing! ✔️ done 😉 |
Member
|
@alexanderadam It's not happy with the TOC, missing the new entry, correct please? |
alexanderadam
force-pushed
the
doc/update_reload_documentation_for_current_Rails_versions
branch
from
0311f28 to
7c037c4
Compare
Contributor
Author
|
Done. The Markdown changes are more complicated as the Ruby changes it seems 😆 |
dblock
approved these changes
Nov 6, 2025
Member
It's not you, it's me, I promise! Thanks so much for your contribution. |
alexanderadam
deleted the
doc/update_reload_documentation_for_current_Rails_versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #358
PS: I'm looking for a new adventure in case anybody is looking to hire or work with a Ruby/Rails/Crystal dev