upgrade rubocop version #1716
Merged
upgrade rubocop version #1716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of a CHANGELOG.md entry: * [#1716](https://github.com/ruby-grape/grape/pull/1716): Upgrade rubocop version - [@namusyaka](https://github.com/namusyaka).Generated by 🚫 danger |
Member
|
You should upgrade to the latest rubocop, fix appraisals and what not, too. Then |
namusyaka
force-pushed
the
update-rubocop
branch
2 times, most recently
from
a35f9e0 to
15f5bcd
Compare
Contributor
Author
|
Fixed. |
Member
|
Thanks. The encoding header was removed everywhere, which is right, but a newline was added instead. Care to fix that? Sorry to be a pest :) |
dblock
reviewed
Dec 11, 2017
| @@ -1,4 +1,4 @@ | |||
| # encoding: utf-8 | |||
|
|
|||
Fixes potential security vulnerability. ref https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-8418 Also this commit contains appraisals and rubocop updates
namusyaka
force-pushed
the
update-rubocop
branch
from
15f5bcd to
0dc2436
Compare
Contributor
Author
|
Oh.. sorry. Thanks for pointing this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes potential security vulnerability.
ref https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-8418