Support Faraday version 2.x #63
Merged
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't have to support both versions. Let's move to Faraday 2.x. Older versions of this client will cover the needs of a very large percentage of users who may still be stuck on Faraday 1.x for any reason. |
|
Thank you for contributing, by the way :) |
Sure. I have removed the version check and made it simple. |
michaelklishin
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Faraday 2.x. For this upgrade the Faraday Upgrading guide was used.
Unfortunately basic authentication implementations for Faraday 1.x and 2.x are completely different and therefore I had to add a version check to support both versions.