Not working on iOS after RN upgrade to 0.59.2

[alexandrius]

Hello. I just upgraded to 0.59.2.
It's seems Android version is working just fine while iOS doesn't.
It works on debug but fails to work on release.

[alexandrius]

I created this patch after it's working:

diff --git a/node_modules/redux-persist/lib/storage/index.native.js b/node_modules/redux-persist/lib/storage/index.native.js
index 9cba57d..026d4d2 100644
--- a/node_modules/redux-persist/lib/storage/index.native.js
+++ b/node_modules/redux-persist/lib/storage/index.native.js
@@ -2,7 +2,7 @@
 
 exports.__esModule = true;
 
-var _reactNative = require('react-native');
+import AsyncStorage from '@react-native-community/async-storage';
 
-exports.default = _reactNative.AsyncStorage; // @noflow
+exports.default = AsyncStorage; // @noflow
 /* eslint-disable */
\ No newline at end of file
diff --git a/node_modules/redux-persist/src/storage/index.native.js b/node_modules/redux-persist/src/storage/index.native.js
index 641e10f..6dcc965 100644
--- a/node_modules/redux-persist/src/storage/index.native.js
+++ b/node_modules/redux-persist/src/storage/index.native.js
@@ -1,6 +1,6 @@
 // @noflow
 /* eslint-disable */
 
-import { AsyncStorage } from 'react-native'
+import AsyncStorage from '@react-native-community/async-storage';
 
 export default AsyncStorage

[iagormoraes]

AsyncStorage is now an outer package from RN, I think we should apply in a parameter the storage at the time of store configuration like:

import storage from 'redux-persist/lib/storage';
import { AsyncStorage } from 'react-native' // RN <= 58 
import AsyncStorage from '@react-native-community/async-storage'; // RN >= 59

const persistConfig = {
    key: 'root',
    storage: storage(AsyncStorage),
    stateReconciler: autoMergeLevel2,
    blacklist: [
        'transactions',
        'onboarding'
    ]
};

...

[Buwaneka-Sumanasekara]

import AsyncStorage from '@react-native-community/async-storage'; 
const persistConfig = {
    key: 'root',
    storage: AsyncStorage
}

[iagormoraes]

import AsyncStorage from '@react-native-community/async-storage'; 
const persistConfig = {
    key: 'root',
    storage: AsyncStorage
}

This way works or is a proposal, because storage method have your conditions to use the proper storage based on web/native.

[danielgreane]

This doesn't quite seem to do it for me... I have:

• imported AsyncStorage from @react-native-community/async-storage and set it in my persistConfig as the storage
• Patched index.native.js to use the community package

This works fine for a fresh install, however when upgrading from an old version that used react-native core's AsyncStorage --> a version with the new changes above, the old persisted data is not read correctly on rehydrate. It's more likely that this is a difference between async-storage

For the time being I've had to revert to RN core's async storage and live with the warning message

Has anyone else experience similar issues?

[alexandrius]

@danielgreane You need to patch redux-persist/lib/storage/index.native.js

[danielgreane]

@alexandrius I've patched it... it works fine in the sense that it uses the new community package to read and write after initial install, however the initial read using the new package returns no data from the older installed version

Steps to reproduce:

1. Install the old version onto the simulator, write something to your store that you'd like to persist
2. Follow your steps above (patch index.native.js and specify storage from the new community package)
3. Re-install to the emulator without deleting the app from step 1
4. Observe that the old data is not persisted from the old version

[danielgreane]

Ok, I think this is probably the issue:

react-native-async-storage/async-storage#64

Looks like they're using a new key name in the community version... nothing to do with redux-persist but hopefully someone comes across this and knows to hold off migrating to the community version until the above PR is merged!

[bwillem]

This should not be a breaking change though - reactNative.asyncStorage is still in the bundle, it's just deprecated. why does is break?

[iagormoraes]

@bwillem as the documentation says Deprecated. Use react-native-community/react-native-async-storage instead., is recommended to not use it as it may be removed in 0.60, even tough redux-persist updated and removed this dependency so you just need to install community one.