Skip to content

Conversation

RLumSK
Copy link
Contributor

@RLumSK RLumSK commented Nov 3, 2020

This PR includes the already announced final fix for #331, which was released by Copernicus today in the morning.

  • Unless you have done it in any other RStudio's projects before, please sign the individual or corporate contributor agreement for a significant pull request (it is fine not to sign it if a PR is only intended to fix a few typos). You can send the signed copy to [email protected].

  • Update NEWS.

@cderv
Copy link
Collaborator

cderv commented Nov 3, 2020

Great ! Have you tested it on previous and newer version of Latex ? Do you know if it is expected to work with new and old version ?
Just wondering if we should watch out for that.

@cderv
Copy link
Collaborator

cderv commented Nov 3, 2020

From my test it is working ok !

@cderv cderv merged commit 4340348 into rstudio:master Nov 3, 2020
@cderv
Copy link
Collaborator

cderv commented Nov 3, 2020

Thank you @RLumSK !

@RLumSK
Copy link
Contributor Author

RLumSK commented Nov 3, 2020

@cderv Sorry, I should have mentioned this little but important detail: Yes, of course, I had tested it before the PR. I've tried TeXLive 2015 to 2020, and all worked. Besides, before I created the PR, I was in contact with Copernicus because they had also asked me to test the new version + they tested it on their end. Hence, I would say: It should be fine.

@cderv
Copy link
Collaborator

cderv commented Nov 3, 2020

Awesome! Thank you a lot!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants