Release rspec-rails 4

[benoittgt]

Hello

This is an issue to follow the release of rspec-rails 4.

As mentioned in #2242 (comment) we have pending PR/issue that needs review or work.

I think we should tag them with v4.0 or set a milestone to help us to work on.

At the moment I don't know where I could help.

Thanks 🌝

[JonRowe]

I think its just #2242 and #1938 that are really holding me off releasing

[klyonrad]

I think that this behaviour (scaffolding creates controller specs and empty request spec that I introduced would irritate some users. Please check if you can confirm this problem

[micodel]

Why update the README to state 4.0 before its release?

Could not find gem 'rspec-rails (~> 4.0)' in any of the gem sources listed in your Gemfile.

[JonRowe]

Readme refers to the current branch and commit, the relevant branches refer to their relevant versions.

@micodel I've added a note making this more clear. Its common practise however.

[micodel]

I'm sure you are more experienced than me 😅, but what about having some sort of versioned 4.0 rc branch with a living README, and letting master (aka the main page README) reflect the latest stable release? I have seen this implemented in other gems and its a nice touch

[JonRowe]

Thats really not how Github works, the default branch is the target of all PRs and is thus expected to be the core development branch, you can change what that branch is but it is always the default landing branch. Thus you should always assume the README.md is for the development branch and check the releasing strategy accordingly.

[JonRowe]

We could not have the current version being worked on in the readme but we've been on the verge of releasing 4.0.0 for months so we updated it when we merged that branch ready to release and it just hasn't happened yet 😂

[benoittgt]

I think we can already release the 4.0. Then iterate for the upcoming features.

But maybe @JonRowe you want to fix the remaning issue/pr first? https://github.com/rspec/rspec-rails/labels/v4.0

[klyonrad]

As mentioned, I introduced a bug with the generate request specs PR

this behaviour (scaffolding creates controller specs and empty request spec

So maybe we should revert it, release and then iterate

[JonRowe]

So we need to release those remaining issues in a major release, so if not 4.0.0 then they'll have to wait until 5.0.0 however I really don't want to ship controller specs generated in 4.0.0

[JonRowe]

I'm going to ship the latest changes as rc1 at some point today, and maybe look towards releasing fully next week.

[JonRowe]

So 4.0.0 is on rubygems (🎉 ) but these still need doing:

• docs on rspec.info
• docs on relish
• blog post about 4.0.0 and the "journey" thanking everyone
• announce it