adds routing example with TaggingMetadata and CompositeMetadata #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleh Dokuka <[email protected]> Signed-off-by: Oleh Dokuka <[email protected]> Signed-off-by: Oleh Dokuka <[email protected]>
OlegDokuka
force-pushed
the
docs/routing-example
branch
from
e25b4f5 to
3f65c48
Compare
rstoyanchev
approved these changes
Mar 23, 2022
Contributor
rstoyanchev
left a comment
rstoyanchev
left a comment
There was a problem hiding this comment.
Looks good, just one minor point on the payload release inside an if-condition.
| logger.info("Received RequestResponse[route={}]", route); | ||
|
|
||
| if ("my.test.route".equals(route)) { | ||
| payload.release(); |
Contributor
There was a problem hiding this comment.
Not sure why the payload release is inside the if condition? It doesn't seem related.
| logger.info("Received RequestResponse[route={}]", route); | ||
|
|
||
| if ("my.test.route".equals(route)) { | ||
| payload.release(); |
Signed-off-by: Oleh Dokuka <[email protected]> Signed-off-by: Oleh Dokuka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleh Dokuka [email protected]
Signed-off-by: Oleh Dokuka [email protected]