Lazy load type mappings #2296
Closed
Lazy load type mappings #2296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In hopes of allowing the configuration for emulate_booleans to get set before it is evaluated.
Contributor
Author
|
This fixes the new test case. And works in my applications. Unfortunately, it also triggers some other test failures. Sadly, without being able to reproduce your test environment locally (https://github.com/yahonda/rails-dev-box/issues/43), I do not have the means to pursue the other test failures. |
andynu
force-pushed
the
lazy-load-type-mappings
branch
from
6f0ec94 to
b7a23d9
Compare
andynu
force-pushed
the
lazy-load-type-mappings
branch
from
b7a23d9 to
babe6b7
Compare
Collaborator
|
Would you create a pull request to master branch first? I'll backport it to release70 branch if necessary. |
Contributor
Author
|
Sure. #2300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to fix issue #2256. I believe it should have the same memory implications as the intention in #2199. The type maps are loaded once when they are first called. Only one instance of the mapping is ever created.
Fortunately this was enough to solve the problem, but if there were a need, this could easily be worked into the clear_cache! API to reset it at a later point in the application just by setting the @type_map to nil.