Enabled RSpec/RepeatedDescription cop
#2279
Merged
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These offenses are fixed manually.
```ruby
$ bundle exec rubocop
Inspecting 72 files
...............................................C...C.C..................
Offenses:
spec/active_record/connection_adapters/oracle_enhanced/dbms_output_spec.rb:50:3: C: RSpec/RepeatedDescription: Don't repeat descriptions within an example group.
it "should log dbms output lines to the rails log" do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/active_record/connection_adapters/oracle_enhanced/dbms_output_spec.rb:60:3: C: RSpec/RepeatedDescription: Don't repeat descriptions within an example group.
it "should log dbms output lines to the rails log" do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb:884:5: C: RSpec/RepeatedDescription: Don't repeat descriptions within an example group.
it "should add lob column with non_default tablespace" do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb:892:5: C: RSpec/RepeatedDescription: Don't repeat descriptions within an example group.
it "should add lob column with non_default tablespace" do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb:81:7: C: RSpec/RepeatedDescription: Don't repeat descriptions within an example group.
it "should get primary key from database at first time" do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb:86:7: C: RSpec/RepeatedDescription: Don't repeat descriptions within an example group.
it "should get primary key from database at first time" do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
72 files inspected, 6 offenses detected
$
```
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables
RSpec/RepeatedDescriptioncop.These offenses are fixed manually.