Skip to content

Conversation

@yahonda
Copy link
Collaborator

@yahonda yahonda commented Mar 1, 2022

yahonda added 2 commits March 1, 2022 19:52
```
$ yamllint .
./.travis.yml
  17:31     warning  missing starting space in comment  (comments)
  18:31     warning  missing starting space in comment  (comments)
  59:5      error    wrong indentation: expected 2 but found 4  (indentation)

./.rubocop.yml
  282:4     error    wrong indentation: expected 2 but found 3  (indentation)

./.github/workflows/test.yml
  51:5      error    wrong indentation: expected 6 but found 4  (indentation)

./.github/workflows/ruby.yml
  15:5      error    wrong indentation: expected 6 but found 4  (indentation)
```
@yahonda yahonda requested a review from koic March 1, 2022 11:08
@yahonda
Copy link
Collaborator Author

yahonda commented Mar 1, 2022

@koic Would you review this pull request because you've made rubocop/rubocop-rails#645 .

Copy link
Collaborator

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems better to squash the commits into one, but it's up to you. Anyway this change looks good to me.

@yahonda yahonda merged commit 058e0a5 into rsim:master Mar 1, 2022
@yahonda
Copy link
Collaborator Author

yahonda commented Mar 1, 2022

Thanks for the review. Merged using Squash and Merge.

@yahonda yahonda deleted the yamllint branch March 1, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants