support LOB equality #2258
Merged
support LOB equality #2258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akostadinov
force-pushed
the
oci8
branch
3 times, most recently
from
c8b3718 to
8e98310
Compare
akostadinov
commented
Feb 2, 2022
Comment on lines
+30
to
+43
|
|
||
| def cached_column_for(attr) | ||
| return unless Arel::Attributes::Attribute === attr | ||
|
|
||
| table = attr.relation.table_name | ||
| return unless schema_cache.columns_hash?(table) | ||
|
|
||
| column = attr.name.to_s | ||
| schema_cache.columns_hash(table)[column] | ||
| end | ||
|
|
||
| def schema_cache | ||
| @connection.schema_cache | ||
| end |
Contributor
Author
There was a problem hiding this comment.
These two methods are mostly logic from arel 7.1.4 with the difference that we only obtain cached columns. Otherwise we go into troubles trying to build the cache.
|
@yahonda Example: This supposed to fire a query as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2239