Fix columns_for_distinct when using Rails 6.1 #2249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `ARCONN=oracle bundle exec ruby -Itest ./test/cases/finder_test.rb -n test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct` in Rails 6.1.4.4 will result in an error. ``` ARCONN=oracle bundle exec ruby -Itest ./test/cases/finder_test.rb -n test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct Using oracle Warning: NLS_LANG is not set. fallback to US7ASCII. Run options: -n test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct --seed 32511 # Running: F Failure: FinderTest#test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct [./test/cases/finder_test.rb:1503]: Expected: 2 Actual: 1 rails test ./test/cases/finder_test.rb:1502 Finished in 1.275346s, 0.7841 runs/s, 0.7841 assertions/s. 1 runs, 1 assertions, 1 failures, 0 errors, 0 skips ``` Changing the return value of `columns_for_distinct` causes the test to pass. This is a fix for the change to PostgreSQL and MySQL adapters in Rails 6.0. rails/rails#31966 The reason why the tests for `ARCONN=oracle bundle exec ruby -Itest ./test/cases/finder_test.rb -n test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct` don't pass is because of a fix in finder_methods.rb in Rails 6.1. rails/rails@2ad2425
|
Thanks for opening a pull request. Would you make sure this test fails against Rails main branch (7.1.0.alpha) and Oracle enhanced adapter master branch? If so, I'm happy to merge this pull request and backport them to release70 and release61 branches. |
|
Tests failed on the Rails main branch and Oracle enhanced adapter master branch. |
|
Thank you for the confirmation. Let me backport it to release70 and release61 branches. |
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Jan 20, 2022
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Jan 20, 2022
yahonda
added a commit
that referenced
this pull request
Jan 20, 2022
Merge pull request #2249 from swamp09/fix_columns_for_distinct
yahonda
added a commit
that referenced
this pull request
Jan 20, 2022
Merge pull request #2249 from swamp09/fix_columns_for_distinct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
ARCONN=oracle bundle exec ruby -Itest ./test/cases/finder_test.rb -n test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinctin Rails 6.1.4.4 will result in an error.Fixing the return value of
columns_for_distinctcauses the test to pass.This is a fix for the change to PostgreSQL and MySQL adapters in Rails 6.0. rails/rails#31966
The reason why the tests for
ARCONN=oracle bundle exec ruby -Itest ./test/cases/finder_test.rb -n test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinctdon't pass is because of a fix in finder_methods.rb in Rails 6.1.rails/rails@2ad2425