Enable Layout/ClosingParenthesisIndentation cop

[yahonda]

This pull request enables Layout/ClosingParenthesisIndentation cop.

$ bundle exec rubocop
Inspecting 70 files
........C..............C..............................................

Offenses:

lib/active_record/connection_adapters/oracle_enhanced/context_index.rb:163:17: C: [Correctable] Layout/ClosingParenthesisIndentation: Indent ) to column 14 (not 16)
                } BEGIN
                ^
lib/active_record/connection_adapters/oracle_enhanced/context_index.rb:197:19: C: [Correctable] Layout/ClosingParenthesisIndentation: Indent ) to column 16 (not 18)
                  }
                  ^
lib/active_record/connection_adapters/oracle_enhanced/schema_statements.rb:672:23: C: [Correctable] Layout/ClosingParenthesisIndentation: Indent ) to column 12 (not 22)
                      )
                      ^

70 files inspected, 3 offenses detected, 3 offenses auto-correctable

Refer rails/rails@d7fce6c
https://github.com/rubocop/rubocop/blame/master/relnotes/v1.18.0.md#L11

[yahonda]

@koic Would you review this pull request ?

[koic]

The following may make the pair of parentheses even clearer.

@@ -153,14 +153,14 @@ module ActiveRecord
                 (p_rowid IN          ROWID,
                 p_clob IN OUT NOCOPY CLOB) IS
                 -- add_context_index_parameters #{(column_names + select_queries).inspect}#{!options.empty? ? +', ' << options.inspect[1..-2] : ''}
-                #{
+              #{
                 selected_columns.map do |cols|
                   cols.map do |col|
                     raise ArgumentError, "Alias #{col} too large, should be 28 or less characters long" unless col.length <= 28
                     "l_#{col} VARCHAR2(32767);\n"
                   end.join
                 end.join
-                } BEGIN
+              } BEGIN
                 FOR r1 IN (
                   SELECT #{quoted_column_names.join(', ')}
                   FROM  #{quoted_table_name}

[yahonda]

Thanks for the review. Updated and pushed.

[koic]

Looks good to me. Can you squash your commits into one?

[yahonda]

Thanks. Squashed commits.

[koic]

Thanks!