Skip to content

Enable Performance/MapCompact cop #2176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Enable Performance/MapCompact cop #2176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,9 @@ Performance/BindCall:
Performance/FlatMap:
Enabled: true

Performance/MapCompact:
Enabled: true

Performance/RedundantMerge:
Enabled: true

Expand Down
4 changes: 2 additions & 2 deletions lib/active_record/connection_adapters/oracle_enhanced/schema_dumper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def synonyms(stream)

def _indexes(table, stream)
if (indexes = @connection.indexes(table)).any?
add_index_statements = indexes.map do |index|
add_index_statements = indexes.filter_map do |index|
case index.type
when nil
# do nothing here. see indexes_in_create
Expand All @@ -67,7 +67,7 @@ def _indexes(table, stream)
statement_parts = ["# unrecognized index #{index.name.inspect} with type #{index.type.inspect}"]
end
" " + statement_parts.join(", ") unless statement_parts.empty?
end.compact
end

return if add_index_statements.empty?

Expand Down