structure dump: read column comments from all_tab_cols #2121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
(The jruby builds appear to be failing for what seems to be unrelated reasons.) |
yahonda
reviewed
Jan 14, 2021
| columns = select_values(<<~SQL.squish, "SCHEMA") | ||
| SELECT /*+ OPTIMIZER_FEATURES_ENABLE('11.2.0.2') */ column_name FROM user_tab_columns | ||
| WHERE table_name = '#{table_name}' ORDER BY column_id | ||
| SELECT /*+ OPTIMIZER_FEATURES_ENABLE('11.2.0.2') */ column_name FROM all_tab_cols |
Collaborator
There was a problem hiding this comment.
Would you explain why all_tab_cols is used not all_tab_columns?
Contributor
Author
There was a problem hiding this comment.
That's my ignorance, sorry! Having read some docs I will swap this out :)
Contributor
Author
There was a problem hiding this comment.
I've force-pushed with this swapped out, thanks for the feedback. 👍
...and filter by owner, rather than using user_tab_columns. Ensures column comments are dumped for the current schema
joshpencheon
force-pushed
the
fix-dumping-column-comments-across-schemas
branch
from
8308f41 to
7156d3d
Compare
Collaborator
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Summary
Currently, when dumping column comments,
user_tab_columnsis used. This misses comments which are in the current schema, when the current user is not the owner.PR Summary
This PR dumps column comments from
all_tab_colsinstead, filteringownerto thecurrent_schema. This is in line with the approach taken for the rest of the objects extracting during the structure dump.