Enable Style/RedundantRegexpEscape cop
#2074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up rails/rails@a908d06 ``` $ bundle exec rubocop -a Inspecting 70 files .............C.....C........................C....C.CC................. Offenses: lib/active_record/connection_adapters/oracle_enhanced/jdbc_connection.rb:116:41: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal unless database.match?(/^(\:|\/)/) ^^ lib/active_record/connection_adapters/oracle_enhanced/quoting.rb:15:32: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal if /\A[a-z][a-z_0-9\$#]*\Z/.match?(name) ^^ lib/active_record/connection_adapters/oracle_enhanced/quoting.rb:30:31: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal when /^[a-z][a-z_0-9\$#]*$/ ^^ lib/active_record/connection_adapters/oracle_enhanced/quoting.rb:32:31: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal when /^[a-z][a-z_0-9\$#\-]*$/i ^^ spec/active_record/connection_adapters/oracle_enhanced/context_index_spec.rb:329:80: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(output).to match(/add_context_index "posts", \["title"\], name: \"index_posts_on_title\"$/) ^^ spec/active_record/connection_adapters/oracle_enhanced/context_index_spec.rb:329:102: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(output).to match(/add_context_index "posts", \["title"\], name: \"index_posts_on_title\"$/) ^^ spec/active_record/connection_adapters/oracle_enhanced/schema_dumper_spec.rb:74:41: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(output).to match(/t.string \"special_c\", default: "\\n"/) ^^ spec/active_record/connection_adapters/oracle_enhanced/schema_dumper_spec.rb:74:52: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(output).to match(/t.string \"special_c\", default: "\\n"/) ^^ spec/active_record/connection_adapters/oracle_enhanced/schema_dumper_spec.rb:107:40: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(output).to match(/t.ntext \"ntext_column\"/) ^^ spec/active_record/connection_adapters/oracle_enhanced/schema_dumper_spec.rb:107:54: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(output).to match(/t.ntext \"ntext_column\"/) ^^ spec/active_record/connection_adapters/oracle_enhanced/schema_dumper_spec.rb:373:68: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(output).to match(/t\.virtual "name_ratio",(\s*)as:(.*)\"$/) # no :type ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:71:42: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_FOO\"? FOREIGN KEY \(\"?FOO_ID\"?\) REFERENCES \"?FOOS\"?\(\"?ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:71:55: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_FOO\"? FOREIGN KEY \(\"?FOO_ID\"?\) REFERENCES \"?FOOS\"?\(\"?ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:71:74: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_FOO\"? FOREIGN KEY \(\"?FOO_ID\"?\) REFERENCES \"?FOOS\"?\(\"?ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:71:93: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_FOO\"? FOREIGN KEY \(\"?FOO_ID\"?\) REFERENCES \"?FOOS\"?\(\"?ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:71:111: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_FOO\"? FOREIGN KEY \(\"?FOO_ID\"?\) REFERENCES \"?FOOS\"?\(\"?ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:71:120: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_FOO\"? FOREIGN KEY \(\"?FOO_ID\"?\) REFERENCES \"?FOOS\"?\(\"?ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:71:137: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_FOO\"? FOREIGN KEY \(\"?FOO_ID\"?\) REFERENCES \"?FOOS\"?\(\"?ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:71:144: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_FOO\"? FOREIGN KEY \(\"?FOO_ID\"?\) REFERENCES \"?FOOS\"?\(\"?ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:71:149: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_FOO\"? FOREIGN KEY \(\"?FOO_ID\"?\) REFERENCES \"?FOOS\"?\(\"?ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:71:154: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_FOO\"? FOREIGN KEY \(\"?FOO_ID\"?\) REFERENCES \"?FOOS\"?\(\"?ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:91:42: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_BAZ\"? FOREIGN KEY \(\"?BAZ_ID\"?\) REFERENCES \"?FOOS\"?\(\"?BAZ_ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:91:55: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_BAZ\"? FOREIGN KEY \(\"?BAZ_ID\"?\) REFERENCES \"?FOOS\"?\(\"?BAZ_ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:91:74: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_BAZ\"? FOREIGN KEY \(\"?BAZ_ID\"?\) REFERENCES \"?FOOS\"?\(\"?BAZ_ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:91:93: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_BAZ\"? FOREIGN KEY \(\"?BAZ_ID\"?\) REFERENCES \"?FOOS\"?\(\"?BAZ_ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:91:111: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_BAZ\"? FOREIGN KEY \(\"?BAZ_ID\"?\) REFERENCES \"?FOOS\"?\(\"?BAZ_ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:91:120: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_BAZ\"? FOREIGN KEY \(\"?BAZ_ID\"?\) REFERENCES \"?FOOS\"?\(\"?BAZ_ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:91:137: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_BAZ\"? FOREIGN KEY \(\"?BAZ_ID\"?\) REFERENCES \"?FOOS\"?\(\"?BAZ_ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:91:144: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_BAZ\"? FOREIGN KEY \(\"?BAZ_ID\"?\) REFERENCES \"?FOOS\"?\(\"?BAZ_ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:91:149: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_BAZ\"? FOREIGN KEY \(\"?BAZ_ID\"?\) REFERENCES \"?FOOS\"?\(\"?BAZ_ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:91:158: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_BAZ\"? FOREIGN KEY \(\"?BAZ_ID\"?\) REFERENCES \"?FOOS\"?\(\"?BAZ_ID\"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:139:30: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/\"?ID_PLUS\"? NUMBER GENERATED ALWAYS AS \(ID\+2\) VIRTUAL/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:139:40: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/\"?ID_PLUS\"? NUMBER GENERATED ALWAYS AS \(ID\+2\) VIRTUAL/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:152:43: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"SUPER\" RAW\(255\) GENERATED ALWAYS AS \(HEXTORAW\(TO_CHAR\(ID\)\)\) VIRTUAL/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:152:49: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"SUPER\" RAW\(255\) GENERATED ALWAYS AS \(HEXTORAW\(TO_CHAR\(ID\)\)\) VIRTUAL/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:152:57: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"SUPER\" RAW\(255\) GENERATED ALWAYS AS \(HEXTORAW\(TO_CHAR\(ID\)\)\) VIRTUAL/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:152:61: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"SUPER\" RAW\(255\) GENERATED ALWAYS AS \(HEXTORAW\(TO_CHAR\(ID\)\)\) VIRTUAL/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:152:91: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"SUPER\" RAW\(255\) GENERATED ALWAYS AS \(HEXTORAW\(TO_CHAR\(ID\)\)\) VIRTUAL/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:152:98: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"SUPER\" RAW\(255\) GENERATED ALWAYS AS \(HEXTORAW\(TO_CHAR\(ID\)\)\) VIRTUAL/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:164:43: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"NCLOB_TEXT\" NCLOB/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:164:49: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"NCLOB_TEXT\" NCLOB/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:164:57: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"NCLOB_TEXT\" NCLOB/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:164:61: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"NCLOB_TEXT\" NCLOB/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:164:91: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"NCLOB_TEXT\" NCLOB/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:164:103: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"NCLOB_TEXT\" NCLOB/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:190:63: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE INDEX "?IX_TEST_POSTS_FOO\"? ON "?TEST_POSTS"? \("?FOO"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:202:70: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE INDEX "?IX_TEST_POSTS_FOO_FOO_ID\"? ON "?TEST_POSTS"? \("?FOO"?, "?FOO_ID"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:203:68: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE INDEX "?IX_TEST_POSTS_FUNCTION\"? ON "?TEST_POSTS"? \(TO_CHAR\(LENGTH\("?FOO"?\)\)\|\|"?FOO"?\)/i) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:215:43: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"SUPER\" RAW\(255\)/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:215:49: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"SUPER\" RAW\(255\)/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:215:57: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"SUPER\" RAW\(255\)/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:215:61: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"SUPER\" RAW\(255\)/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:215:91: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"SUPER\" RAW\(255\)/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:215:98: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(dump).to match(/CREATE TABLE \"BARS\" \(\n \"ID\" NUMBER\(38,0\) NOT NULL,\n \"SUPER\" RAW\(255\)/) ^^ spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:272:56: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal it { is_expected.to_not match(%r{CREATE SEQUENCE \"#{sequence_name}" MAXVALUE \d+ MINVALUE \d+ NOORDER NOCYCLE}) } ^^ spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb:102:67: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(@logger.logged(:debug).first).not_to match(/SELECT \"TEST_EMPLOYEES_SEQ\".NEXTVAL FROM dual/im) ^^ spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb:102:87: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(@logger.logged(:debug).first).not_to match(/SELECT \"TEST_EMPLOYEES_SEQ\".NEXTVAL FROM dual/im) ^^ spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb:105:63: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(@logger.logged(:debug).first).to match(/SELECT \"TEST_EMPLOYEES_SEQ\".NEXTVAL FROM dual/im) ^^ spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb:105:83: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal expect(@logger.logged(:debug).first).to match(/SELECT \"TEST_EMPLOYEES_SEQ\".NEXTVAL FROM dual/im) ^^ 70 files inspected, 59 offenses detected, 59 offenses corrected Tip: Based on detected gems, the following RuboCop extension libraries might be helpful: * rubocop-rake (http://github.com/rubocop-hq/rubocop-rake) * rubocop-rspec (http://github.com/rubocop-hq/rubocop-rspec) You can opt out of this message by adding the following to your config (see https://docs.rubocop.org/rubocop/extensions.html#extension-suggestions for more options): AllCops: SuggestExtensions: false $ ```
|
@koic Just wanted to get your review because it adds the new cop. |
|
I've found we need to support rails/rails@59f7f58 will create another pull request or commit soon. |
koic
approved these changes
Dec 9, 2020
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up rails/rails@a908d06