Missing c-tor invocation #2048
Merged
Missing c-tor invocation #2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `NoMethodError: undefined method `ArgumentError' for #<ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter:>`
Collaborator
|
Thanks for the review. I'd need some specs to avoid future regressions. |
Collaborator
|
I mean I'm happy to backport this change to release60 branch with specs. |
Collaborator
|
Nevermind. Merging this pull request. |
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Sep 15, 2020
Missing c-tor invocation
yahonda
added a commit
that referenced
this pull request
Sep 16, 2020
Merge pull request #2048 from gavvvr/patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
NoMethodError: undefined methodArgumentError' for #ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter:`