How to prevent from including ojdbc8.jar file to gem file

[yahonda]

Oracle enhanced adapter 6.1.3 has been deleted because it includes ojdbc8.jar file.

.gitignore already has ojdbc*.jar then it will not be pushed to git repository but it should not prevent from including this file bundle exec rake build.

$ gem unpack activerecord-oracle_enhanced-adapter-6.1.3.gem
$ cd activerecord-oracle_enhanced-adapter-6.1.3/lib$ ls
active_record  activerecord-oracle_enhanced-adapter.rb  arel  ojdbc8.jar

$ gem yank activerecord-oracle_enhanced-adapter -v 6.1.3
Yanking gem from https://rubygems.org...
You have enabled multi-factor authentication. Please enter OTP code.
Code:   ******
Successfully deleted gem: activerecord-oracle_enhanced-adapter (6.1.3)

[koic]

Thank you for your activities.

The gemspec uses Dir[]. It has nothing to do with .gitignore (and git system), and files under lib directory are bundled in the distribution gem.

s.files = Dir["History.md", "License.txt", "README.md", "VERSION", "lib/**/*"]

https://github.com/rsim/oracle-enhanced/blob/v6.1.3/activerecord-oracle_enhanced-adapter.gemspec#L20

It can be reproduced below.

% touch lib/ojdbc8.jar
% ruby -e 'p Dir["History.md", "License.txt", "README.md", "VERSION", "lib/**/*"]'
# => [... , "lib/ojdbc8.jar"] # Contains `lib/ojdbc8.jar`.

For a workaround, move ojbc8.jar from lib directory and release it.

In the future, I think jars (or vendor?) directory will be created and moved to jars/ojbc8.jar (Needs to be added to .gitignore and CLASSPATH). Of course, I think there are other ways :-)

[yahonda]

Thanks for the suggestion. What do you think about using FileList to exclude JDBC drivers? I'd like to exclude ojdbc8.jar and other versions of Oracle JDBC driver from lib directory.

FileList["History.md", "License.txt", "README.md", "VERSION", "lib/**/*"].exclude('lib/ojdbc*.jar')

[koic]

I think it's one approach.

OTOH, I'm not sure if it's a good approach to include 3rd party vendor JAR file for development in lib directory. Anyway, that is an off topic.

[yahonda]

OTOH, I'm not sure if it's a good approach to include 3rd party vendor JAR file for development in lib directory. Anyway, that is an off topic.

Understood. Now it allows JDBC driver under ./lib directory as follows. To keep the compatibility at least it needs to use Oracle JDBC driver under ./lib directory for Rails 6.1 or lower. Also, now Rails 7 alpha does not support JRuby yet because Rails 7 requires Ruby 2.7. I'd like to keep as it is unless JRuby is ready to support Rails 7.

oracle-enhanced/lib/active_record/connection_adapters/oracle_enhanced/jdbc_connection.rb

Line 26 in 218161a

["./lib"].concat($LOAD_PATH).concat(env_path).detect do |dir|

[koic]

Ah, I get it! Thank you for your explanation.