Fix cv assignment in calc.py #457
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_build_rdms expects this to be the actual fold assignment list, not the descriptor name.
|
Hmm, I see that maybe _build_rdms is expecting the cv_descriptor, even tho the type hint wants an array. Should the type hint be for |
|
I think the intention is for this to be a string. I.e. a name of one of the existing descriptors. The type annotation is wrong, it should be |
|
Also I can't find anywhere where that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_build_rdms expects this to be the actual fold assignment list, not the descriptor name. Converted it to an NDArray to match the type hint in build_rdm.py.