Remove runtime dependency on classnames & babel-polyfill #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The VersionEye failure appears to be caused by the custom version of |
Merged
eemeli
added a commit
to maailma/kansa
that referenced
this pull request
Oct 9, 2016
eemeli
added a commit
to maailma/kansa-client
that referenced
this pull request
Nov 7, 2016
|
Amazing! Thanks! 💯 |
This was referenced Feb 12, 2017
eemeli
added a commit
to maailma/kansa
that referenced
this pull request
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does much the same as PR #64 for solving issue #49, but rather than creating a custom
classnamesreplacement, it changes the call parameters ofcreateProps()to expect an array of class names that it then filters.This PR also resolves #51 by adding an inline
isInteger()replacement forNumber.isInteger(), which isn't supported by IE. I also dropped thephantomjs-polyfilldependency as it's not needed.