Skip to content

Only require commit message to be non-empty #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Only require commit message to be non-empty #361

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fc2c2d
Only require commit message to be non-empty.
sarnesjo Jul 16, 2014
fde62d8
Only replace commit message if empty when amending.
sarnesjo Jul 16, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Classes/Controllers/PBGitCommitController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ - (void) commitWithVerification:(BOOL) doVerify
}

NSString *commitMessage = [commitMessageView string];
if ([commitMessage length] < 3) {
if ([commitMessage length] == 0) {
[[repository windowController] showMessageSheet:@"Commitmessage missing" infoText:@"Please enter a commit message before committing"];
return;
}
Expand Down Expand Up @@ -213,9 +213,8 @@ - (void)commitHookFailed:(NSNotification *)notification

- (void)amendCommit:(NSNotification *)notification
{
// Replace commit message with the old one if it's less than 3 characters long.
// This is just a random number.
if ([[commitMessageView string] length] > 3)
// Replace commit message with the old one if it's empty.
if ([[commitMessageView string] length] > 0)
return;

NSString *message = [[notification userInfo] objectForKey:@"message"];
Expand Down